Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: specify type declaration file in package.json #275

Merged
merged 3 commits into from
Oct 8, 2023
Merged

fix: specify type declaration file in package.json #275

merged 3 commits into from
Oct 8, 2023

Conversation

JeukHwang
Copy link
Contributor 

import { P5CanvasInstance, ReactP5Wrapper } from "@p5-wrapper/react";

This line causes the following error.

There are types at '{project-path}/node_modules/@p5-wrapper/react/dist/component/main.d.ts', but this result could not be resolved when respecting package.json "exports". The '@p5-wrapper/react' library may need to update its package.json or typings.ts(7016)

It is resolved when specifying the type declaration file in package.json

@JeukHwang
Copy link
Contributor Author

Thanks for making great package

@jamesrweb
Copy link
Collaborator

Thanks for making great package

Thank you for contributing @JeukHwang, looks good to me 🚀!

I'll fix the CI pipeline upstream and merge this PR once that's done, then I'll make a deployment with a patch version!

@jamesrweb jamesrweb merged commit e9031ad into P5-wrapper:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrweb jamesrweb jamesrweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeukHwang @jamesrweb